Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger instead of fmt.Printf() #2244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use logger instead of fmt.Printf() #2244

wants to merge 1 commit into from

Conversation

EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Jan 16, 2025

Use logger for consistent output, instead of fmt.Printf()

@EmmEff
fix: use logger instead of fmt.Printf()
9d938db 
Use available logger instance, instead of writing directly to stdout with fmt.Printf()

Signed-off-by: Mike Frisch <[email protected]>
@EmmEff EmmEff requested a review from a team as a code owner January 16, 2025 14:55
stevenhorsman
stevenhorsman approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@mkulke mkulke mkulke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmmEff @mkulke @stevenhorsman